fix: validate unique names for monitors #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent missing parameters in existing calls to makeMockReq
mjnagel
reviewed
Aug 15, 2024
mjnagel
reviewed
Aug 15, 2024
…or array to test mocks
mjnagel
reviewed
Aug 21, 2024
mjnagel
pushed a commit
that referenced
this pull request
Jan 15, 2025
🤖 I have created a release *beep* *boop* --- ## [0.34.0](v0.33.1...v0.34.0) (2025-01-15) ### Features * add additional outputs to `debug-output` action ([#1073](#1073)) ([29f12b4](29f12b4)) * istio native sidecars ([#1032](#1032)) ([e07c6dc](e07c6dc)) ### Bug Fixes * add missing resource type `package` to `kubectl describe` failed… ([#1182](#1182)) ([4236b3a](4236b3a)) * attempt fix token permissions ([#1155](#1155)) ([5a46e41](5a46e41)) * remove unnecessary docker command in dev docs task ([#1180](#1180)) ([9906a09](9906a09)) * validate unique names for monitors ([#666](#666)) ([80e28c1](80e28c1)) ### Miscellaneous * add base url field for sso clients ([#1177](#1177)) ([39bef00](39bef00)) * add dev task for docs site ([#1173](#1173)) ([b0c4bc0](b0c4bc0)) * **deps:** bump cross-spawn from 7.0.3 to 7.0.6 ([#1157](#1157)) ([11ddada](11ddada)) * **deps:** update grafana to v1.29.0 ([#1167](#1167)) ([3b31358](3b31358)) * **deps:** update istio to v1.24.2 ([#1135](#1135)) ([0f9552a](0f9552a)) * **deps:** update keycloak to v26.0.8 ([#1171](#1171)) ([1346f7b](1346f7b)) * **deps:** update loki memcached to v1.6.34 ([#1148](#1148)) ([8bbf6b3](8bbf6b3)) * **deps:** update pepr to v0.42.3 ([#1158](#1158)) ([55e8a4e](55e8a4e)) * **deps:** update pepr to v15.3.0 ([#1151](#1151)) ([153b7e1](153b7e1)) * **deps:** update prometheus-stack ([#1137](#1137)) ([8dc0781](8dc0781)) * **deps:** update prometheus-stack ([#1169](#1169)) ([71cab01](71cab01)) * **deps:** update prometheus-stack to v67.9.0 ([#1161](#1161)) ([067df1b](067df1b)) * **deps:** update prometheus-stack to v68.1.0 ([#1176](#1176)) ([7088e78](7088e78)) * **deps:** update support-deps ([#1147](#1147)) ([cf1a60b](cf1a60b)) * **deps:** update support-deps ([#1160](#1160)) ([6c55f6b](6c55f6b)) * **deps:** update vector ([#1165](#1165)) ([abb9584](abb9584)) * **deps:** update velero ([#1150](#1150)) ([29ee12b](29ee12b)) * docs update issue template ([#1163](#1163)) ([21486f9](21486f9)) * **docs:** add doc on non-http ingress ([#1166](#1166)) ([0783525](0783525)) * **docs:** change .md link format to adhere to checker ([#1181](#1181)) ([125a03b](125a03b)) * **docs:** update Flavor Specific Development Notes ([#1153](#1153)) ([bba5a71](bba5a71)) ### Documentation * add note on minimum k3d version, update cli version reference ([#1174](#1174)) ([c4dda4e](c4dda4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new piece to the pepr operator's validator function. The new functionality loops through the Package CR's monitor array, adding each description field (or a dummy string in the event of no provided description) to a set, failing given a duplicate.
The sanitizeResourceName() function was used in the validator since its also used downstream to create the ServiceMonitor resource name based on the string from the monitor.description field.
...
Related Issue
Fixes #656
Type of change
Checklist before merging